Re: [Bug-wget] [PATCH v2 01/27] new Metalink functionalities

[Tim Ruehsen]

On Thursday, September 29, 2016 10:46:52 PM CEST Giuseppe Scrivano wrote:
> Hi Matthew,
> 
> Matthew White <address@hidden> writes:
> > Series of patches to implement new Metalink functionalities.

@Matthew Great work to improve Wget's Metalink support !

Coverity dislikes
    while ((n = FILE_SYSTEM_PREFIX_LEN (p)))
     p += n;
(PW.ASSIGN_WHERE_COMPARE_MEANT)

It is a false positive, but if you make your intention clear like in
    while ((n = FILE_SYSTEM_PREFIX_LEN (p)) > 0)
then Coverity should be silent (there are two places).

> > This series of patches supersedes the following:
> thanks for your work!  I went quickly through it and it seems you
> addressed the reported issues, I will give it another look tomorrow or
> during the weekend.
> Given the size of the changes, I'll wait for other comments before
> merging it though.
> If there are no other comments, I will amend the minor things I reported
> before merging the series without the need of a v3.

@Giuseppe Please go ahead with merging.

Regards, Tim

signature.asc
Description: This is a digitally signed message part.