Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor

[John Ericson]

Hi Ben,

> That wouldn't be much of a testsuite, now, would it? ;-)
>
> Ben

Well, it's randomized property testing akin to [QuickCheck]. The point 
wouldn't be to test the accepted output, but just to ensure the input 
indeed is accepted. The manual tests are the only way to test the 
output, unless we use some sort of alternative spec like [LLVM]'s.

[QuickCheck]: https://en.wikipedia.org/wiki/QuickCheck

[LLVM]: http://llvm.org/doxygen/Triple_8cpp_source.html


----

Anyways so I started moving things but it felt arbitrary: I can't say in 
all cases where to draw the line in 1-component aliases and 
basic-machine short hands. Instead I have a different approach to do the 
deduplication without introducing lots of dead code. The second patch is 
the interesting one; it moves the big patterns to the bottom, as I 
hinted at earlier. This exposes some more overlapping patterns, changing 
behavior and triggering shellcheck (I don't know why the overlap of 
patterns matters to shellcheck, but it does). I think I need you to 
resolve these problems as you see fit. Then, with the basic machine 
checks so reordered, I can simply break the single case into two, and do 
the deduplication, without making any dead code or moving around anything.

The first patch is a few more tests. I'd write more, but I think 
triaging the fallout from patch 2 is more important, after which I can 
write tests with more confidence.

Sound OK?

John

0001-testsuite-config-sub.data-Add-legacy-test-cases.patch
Description: Text document

0002-config.sub-Move-the-big-patterns-to-the-bottom.patch
Description: Text document