config-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: config.sub update broke powerpc-eabivle


From: Dmitry V. Levin
Subject: Re: config.sub update broke powerpc-eabivle
Date: Thu, 7 Jan 2021 02:18:09 +0300

On Thu, Jan 07, 2021 at 09:02:34AM +1030, Alan Modra wrote:
> $ ./config.sub powerpc-eabivle
> Invalid configuration `powerpc-eabivle': OS `eabivle' not recognized
> $ ./config.sub powerpc-unknown-eabivle
> Invalid configuration `powerpc-unknown-eabivle': OS `eabivle' not recognized
> 
> Also powerpc-eabisim and probably some arm configurations.
> Committed to binutils so as to not regress the 2.36 release.  Is this
> OK for upstream?

Thanks, I think this fixes a regression introduced by config.git commit
5e531d391852a54e7fab2d8ff55625fca514b305.  Would you mind adding some
test data to testsuite/config-sub.data and submitting a patch with a
commit message appropriate for config.git (i.e. without information
specific to binutils)?

>       * config.sub: Accept OS of eabi* and gnueabi*.
> 
> diff --git a/config.sub b/config.sub
> index 0cbdae6820..b0f8492348 100755
> --- a/config.sub
> +++ b/config.sub
> @@ -2,7 +2,7 @@
>  # Configuration validation subroutine script.
>  #   Copyright 1992-2021 Free Software Foundation, Inc.
>  
> -timestamp='2021-01-01'
> +timestamp='2021-01-07'
>  
>  # This file is free software; you can redistribute it and/or modify it
>  # under the terms of the GNU General Public License as published by
> @@ -1687,7 +1687,7 @@ case $os in
>       musl* | newlib* | uclibc*)
>               ;;
>       # Likewise for "kernel-libc"
> -     eabi | eabihf | gnueabi | gnueabihf)
> +     eabi* | gnueabi*)
>               ;;
>       # Now accept the basic system types.
>       # The portable systems comes first.
> 
> -- 
> Alan Modra
> Australia Development Lab, IBM

-- 
ldv



reply via email to

[Prev in Thread] Current Thread [Next in Thread]