Re: [coreutils] [PATCH] maint: update sample test template

[Jim Meyering]

Eric Blake wrote:
> * tests/sample-test: Recommend modern idiom.
> ---
>  tests/sample-test |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/tests/sample-test b/tests/sample-test
> index 85a61cf..85b779f 100644
> --- a/tests/sample-test
> +++ b/tests/sample-test
> @@ -16,12 +16,7 @@
>  # You should have received a copy of the GNU General Public License
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>
> -if test "$VERBOSE" = yes; then
> -  set -x
> -  FIXME --version
> -fi

The VERBOSE=yes -> "set -x" part is handled in init.sh, so it's
fine to remove that, but the other, --version-printing part...

It's intended to identify the program(s) under test so that we see in
the log whether it is indeed the just-compiled version or some other.
That particular problem doesn't arise very often, but when it has happened
before, it's been hard to diagnose.

If we retain it, it would have to go *after* the path_prepend_ invocation.

    test "$VERBOSE" = yes && FIXME --version

What do you think?

> -. $srcdir/test-lib.sh
> +. "${srcdir=.}/init.sh"; path_prepend_ ../src
>  # FIXME: skip_if_root_
>  # FIXME: require_root_