|
| From: | Eric Blake |
| Subject: | Re: [coreutils] [PATCHv2] stat: print SELinux context when available |
| Date: | Tue, 05 Oct 2010 05:51:45 -0600 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.4 |
On 10/05/2010 03:03 AM, Jim Meyering wrote:
* src/stat.c (default_format): Don't print SELinux context when in file system (-f) mode, as the context is associated with the file, not the file system. Fix logic inversion, so that in terse mode, %C is included only when is_selinux_enabled and not vice versa.Good catches. Thanks! The above fixes sound fine.
If %C only operates on files, and not file systems, then why do we support %C under -f in the first place? Wouldn't the better patch be to completely remove %C from -f?
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |