Re: [coreutils][patch] seq: User specified terminator

[Jim Meyering]

William Plusnick wrote:
> On Wed, Oct 27, 2010 at 2:40 PM, Jim Meyering <address@hidden> wrote:
>
>     I wrote that comment simply because I thought that
>     hard-coding "\n" might not always be desirable.
>     Given that no one has ever complained, so
>     simply removing the comment might be best.
>
> Agreed, I couldn't think of a use for it. I just didn't want my short
> sightedness to potentially hinder someone else's work who did it. But I agree
> removing the line would be the best solution.
>
> Subject: [PATCH] maint: I took a fixme that was no longer wanted out of seq.
>  *src/seq: took out the comment asking for adding an option to specify the
> terminator string

Thanks.
I'll push this shortly.

>From 30e207fa46f2494563ee82ad850f13e53c922842 Mon Sep 17 00:00:00 2001
From: Patrick W. Plusnick II <address@hidden>
Date: Thu, 28 Oct 2010 14:54:53 +0200
Subject: [PATCH] maint: remove an unnecessary FIXME comment

* src/seq.c (terminator): This does not need to be specifiable
via an option.  Remove the FIXME comment.
---
 src/seq.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/seq.c b/src/seq.c
index c9bdf94..1db7665 100644
--- a/src/seq.c
+++ b/src/seq.c
@@ -46,7 +46,6 @@ static char const *separator;

 /* The string output after all numbers have been output.
    Usually "\n" or "\0".  */
-/* FIXME: make this an option.  */
 static char const terminator[] = "\n";

 static struct option const long_options[] =
-- 
1.7.3.2.191.g2d0e5