Re: coreutils-8.13.29-43a9 vs no-perl

[Jim Meyering]

Bruno Haible wrote:
> On HP-UX 11.00 with gcc:
> FAIL: rm/deep-2
> FAIL: df/total-verify
>
> FAIL: rm/deep-2 (exit: 99)
> ==========================
...
> perl: not found.
> WARNING: `perl' is needed, and is missing on your system.
...
> deep-2: set-up failure:
...

> FAIL: df/total-verify (exit: 1)
> ===============================
...
> perl: not found.
> WARNING: `perl' is needed, and is missing on your system.
...
> + fail=1

Thank you.
Fixed by this:

>From 07e6d9038411d95bae5f9b2201346c861b01ffe2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 9 Oct 2011 09:28:37 +0200
Subject: [PATCH] tests: skip rather than failing when perl is not available

* tests/df/total-verify: Use require_perl_, so that this test is
skipped when perl is not available.
* tests/rm/deep-2: Likewise, and fix wording in a comment.
Reported by Bruno Haible.
---
 tests/df/total-verify |    1 +
 tests/rm/deep-2       |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tests/df/total-verify b/tests/df/total-verify
index bbf2e3b..6098c0e 100755
--- a/tests/df/total-verify
+++ b/tests/df/total-verify
@@ -18,6 +18,7 @@

 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ df
+require_perl_

 df || skip_ "df fails"

diff --git a/tests/rm/deep-2 b/tests/rm/deep-2
index b7651da..d9566aa 100755
--- a/tests/rm/deep-2
+++ b/tests/rm/deep-2
@@ -18,6 +18,7 @@

 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ rm
+require_perl_

 # Root can run this test, but it always succeeds, since for root, all
 # files are writable, and write_protected_non_symlink never reaches
@@ -27,7 +28,7 @@ skip_if_root_
 mkdir x || framework_failure_
 cd x || framework_failure_

-# Construct a hierarchy containing a relative file with a name
+# Construct a hierarchy containing a relative file with a long name
 : ${PERL=perl}
 $PERL \
     -e 'my $d = "x" x 200; foreach my $i (1..52)' \
--
1.7.7.rc0.362.g5a14