|
From: | Bruce Korb |
Subject: | RE: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy |
Date: | Mon, 16 Apr 2012 09:23:05 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
This is on the edge... I generally prefer to use memcpy when the length is already computed, so I propose to do that here. However, this is certainly not performance sensitive, and the strcpy invocation is slightly simpler and hence a little more readable. Opinions?
The "slightly" is sufficiently slight that I'd consider it sub-marginal. Thus I'd give the marginal weight of static analysis tools that object to "strcpy" more weight than this and apply the patch. :-)
[Prev in Thread] | Current Thread | [Next in Thread] |