[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] maint: prohibit an operator at end of line
From: |
Jim Meyering |
Subject: |
Re: [PATCH 3/3] maint: prohibit an operator at end of line |
Date: |
Mon, 30 Apr 2012 16:51:47 +0200 |
Eric Blake wrote:
> On 04/30/2012 07:08 AM, Jim Meyering wrote:
>> Here's a new syntax-check rule (patch 3/3).
>> 1 and 2 fix violations so that the new check passes.
>>
>> For now, this is only in coreutils (grep had only two violations),
>> but given the long list of violations in gnulib's lib/ directory,
>> it may not be generally appealing enough to be added to gnulib's maint.mk:
>>
>> $ git grep -lE '(. [-/+]|&&|\|\|)$' lib
>
> Is it worth adding some more operators, such as *, ^, &, and |?
>
> (. [-/+*^]|&&?|\|\|?)$
I mentioned why "*" is excluded in the cfg.mk comment (too many false
positives for "TYPE *"), and get the feeling that the cost/benefit ratio
is too high for the others, since they are so much less common.
For example, the commenting style in fmt.c provokes many false positives
for "|".