coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests/du/slink.sh: what's the rationale?


From: Pádraig Brady
Subject: Re: tests/du/slink.sh: what's the rationale?
Date: Sun, 20 Jan 2013 15:07:06 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 01/20/2013 12:58 PM, Bernhard Voelker wrote:
On 01/20/2013 01:34 PM, Pádraig Brady wrote:
On 01/20/2013 12:31 PM, Bernhard Voelker wrote:
On 01/20/2013 12:01 PM, Pádraig Brady wrote:
On 01/19/2013 10:33 PM, Bernhard Voelker wrote:
Is tests/du/slink.sh obsolete nowadays?

That test is problematic with various file systems, and the original
test case is already covered by other tests. I'd tend to simply
remove it.

+1


From 8e33c96c68aae6bcd1e97e76d1cb56ea08dc4428 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <address@hidden>
Date: Sun, 20 Jan 2013 13:54:55 +0100
Subject: [PATCH] maint: remove test case du/slink

Looks good.
I'd s/maint:/tests:/ in the summary above
since it fixes a false positive test failure.
"maint" is generally used for stuff only
on internal consequence.

After that you're free to push.

thanks,
Pádraig.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]