Re: [PATCH] use libcrypto routines in gnulib

[Pádraig Brady]

On 12/09/2013 01:40 AM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> Where would be best to initialize this?
> 
> Maybe m4_divert_once([DEFAULTS], [LIB_CRYPTO=])? 

I'll try it out.

>> The libgcrypt replacement calling out to libcrypto seems to work.
>> tests pass anyway.
> 
> I assume you're preparing a
> gnulib patch that would prefer libgcrypt to libcrypto, or
> something like that?

My gnulib patch was just ensuring that
the existing gnulib libgcrypt replacement worked,
as that relies on the gnulib md5 and sha* modules.

> There also seems to be some sentiment
> for preferring gnutls (or nettle or ...) as well.  I'm afraid
> I don't know these libraries that well, but Emacs is already
> using gnutls so it'd probably prefer that to libcrypto.

I'm not going to look at that for a while at least.
gnutls would probably be the next to wrap, and it uses nettle
underneath to provide these routines.
However since the main driver for this is performance,
and libcrypto is currently best in this area,
there _currently_ wouldn't be that much incentive to wrap gnutls,
rather than just using gnulibs routines directly.

thanks,
Pádraig.