[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: use consistent diagnostics with and without inotify
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] tail: use consistent diagnostics with and without inotify |
|
Date: |
Mon, 09 Dec 2013 08:28:32 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 12/09/2013 03:26 AM, Pádraig Brady wrote:
> * src/tail.c: With inotify, when a file is initially absent,
> we fstat(-1) for that file spec, thus recording an errnum of EBADF,
> which caused the "has become accessible" diagnostic to be issued,
> when the file first appears. Instead we avoid the fstat(-1) and
> thus emit the more natural and consistent "has appeared" diagnostic.
> * tests/tail-2/retry.sh: Use the new diagnostic which also causes
> this test to pass on systems without inotify.
Well spotted, thanks!
+1
Have a nice day,
Berny