[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix false failure due to xargs usage
From: |
Bernhard Voelker |
Subject: |
Re: [PATCH] tests: fix false failure due to xargs usage |
Date: |
Mon, 09 Dec 2013 15:52:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/09/2013 02:38 PM, Pádraig Brady wrote:
> * tests/readlink/multi.sh: Ensure there is a trailing delimeter
s/delimeter/delimiter/
> or xargs may (on AIX 7 at least) suppress the last argument.
> ---
> tests/readlink/multi.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/readlink/multi.sh b/tests/readlink/multi.sh
> index 3b91544..dc4ba87 100755
> --- a/tests/readlink/multi.sh
> +++ b/tests/readlink/multi.sh
> @@ -40,7 +40,7 @@ compare exp out || fail=1
> # Note the edge case that the last xargs run may not have a delimiter
> rm out || framework_failure_
> printf '/1\0/1\0/1' > exp || framework_failure_
> -printf '/1 /1 /1' | xargs -n2 readlink -n -m --zero >> out || fail=1
> +printf '/1 /1 /1 ' | xargs -n2 readlink -n -m --zero >> out || fail=1
> compare exp out || fail=1
>
> Exit $fail
Thanks.
This sounds like a severe bug in xargs on AIX 7 ...
To avoid this dubious trailing blank (which might easily be removed
without notice in future), what about:
printf '%s ' /1 /1 /1 | xargs -n2 ...
Thanks & have a nice day,
Berny