Re: My experience with using cp to copy a lot of files (432 millions, 39 TB)

[Bernhard Voelker]

On 09/18/2014 12:57 PM, Pádraig Brady wrote:
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -2198,7 +2198,9 @@ copy_internal (char const *src_name, char const 
> *dst_name,
>                   There we just warn and return here.  */
>                return true;
>              }
> -          else if (x->dereference == DEREF_ALWAYS)
> +          else if (x->dereference == DEREF_ALWAYS
> +                   || (command_line_arg
> +                       && x->dereference == DEREF_COMMAND_LINE_ARGUMENTS))
>              {
>                /* This happens when e.g., encountering a directory for the
>                   second or subsequent time via symlinks when cp is invoked

The comment following the change should be augmented to mention -H, too:

               /* This happens when e.g., encountering a directory for the
                  second or subsequent time via symlinks when cp is invoked
-                 with -R and -L., or with -H.  E.g.,
+                 with -R and -L., or with -H.  E.g.,


Otherwise both patches look good to me.

Thanks & have a nice day,
Berny