Re: [PATCH] tests: make inotify-rotate more robust and efficient

[Bernhard Voelker]

On 10/29/2014 10:20 PM, Pádraig Brady wrote:
>> [  736s] + kill 24570
>> > [  736s] ./tests/tail-2/inotify-rotate.sh: line 65: kill: (24570) - No 
>> > such process
> I was wonderomg did the timeout 40 kill the tail process before it could 
> propagate the "ok"
> I.E. that something recent was slowing down this test causing the false 
> positives?
> Though the the above happened on the first time through the loop so that's 
> not likely.

That's the only possibility - on OBS it's extremely hard to predict
the load on CPU / disk, e.g. tests/rm/ext3-perf.sh is spuriously
failing because rm(1)'s duration exceeds 60 seconds (although we're
using 'make check-very-expensive' without -j N there) ... while it
takes only 14s locally.

However, your patch looks good.

Thanks & have a nice day,
Berny