Re: [PATCH] df: avoid suppressing remote mounts of separate exports

[Pádraig Brady]

On 31/10/14 00:52, Bernhard Voelker wrote:
> On 10/30/2014 05:59 AM, Pádraig Brady wrote:
>> On 10/30/2014 03:44 AM, Pádraig Brady wrote:
>>> On 10/30/2014 02:23 AM, Bernhard Voelker wrote:
>>>> After all, I don't have a strong preference, so I'm probably
>>>> okay with re-introducing duplicate remote file systems.
>>>
>>> I'm 50:50 too. In that case we should probably err
>>> on the side of less code and edge cases.
>>> I.E. not go with with patch.
>>
>> A compromise would be to list the separate exports by default
>> since this is what people are used to, and suppress them
>> in --total mode to support showing the individual file systems
>> which are available and to have an accurate total in that case.
> 
> I somehow don't like the idea that local file systems are treated
> differently than remote ones.  I'm either for showing all or none
> of the duplicates.

I definitely see your point, though we've had _many_ complaints about this.
I think keying the remote deduplication on --total is an acceptable compromise,
and that will also allow us to be even more aggressive in future with
excluding loop devices from the total values if --type is not specified etc.

Attached is a patch is reinstate the separate remote mounts by default.

thanks,
Pádraig.

df-show-remote.patch
Description: Text Data