Re: [PATCH] tests: avoid failure when auto selecting factor tests

[Bernhard Voelker]

On 10/18/2015 03:41 AM, Pádraig Brady wrote:
> * tests/factor/run.sh: If this template is found through
> `grep -El 'print_ver_.* factor'` for example, then just skip it.
__^______________________________^
The closing single quote belongs to the quoting of the grep pattern,
so the `...' doesn't read well here; probably use `grep ... "..."'?

> ---
>  tests/factor/run.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/factor/run.sh b/tests/factor/run.sh
> index 2cf2b47..d984195 100755
> --- a/tests/factor/run.sh
> +++ b/tests/factor/run.sh
> @@ -24,6 +24,8 @@ START=__START__
>    END=__END__
>  CKSUM=__CKSUM__
>  
> +test "$START" = '__START__' && skip_ 'ignoring factor test template'
> +
>  echo "$CKSUM  -" > exp
>  
>  f=1

First of all, I was wondering what you mean by "auto selecting" ...
I for example am using CLI like

  make check SUBSIRS=. TESTS="$( echo tests/PROGRAM/*.sh )"

However, as the __START__ is replaced by the real start value in the
tests t??.sh, those tests are all skipped now, e.g. t21.sh:

  + test 18446744073709551616 = 18446744073709551616
  + skip_ 'ignoring factor test template'

Therefore -1 from me here.

Have a nice day,
Berny