Re: few test failures on various system from recent changes

[Pádraig Brady]

On 16/11/16 01:44, Assaf Gordon wrote:
> Hello all,
> 
> Attached are test logs of some failures on various system (not gnu/linux).
> This includes the recent b2sum patch, and b2sum itself does not fail.
> 
> I haven't investigated further yet, but at least the "tail-2/retry" seems 
> related to the recent truncation change,
> the 'date' on SunOS might be related to the '%q'.
> The 'race' failures on NetBSD might be due to a very slow qemu virtual 
> machine.
> I saw a recent post about Mac OS X fixes, so I'm not posting them.
> 
> SunOS 5.11 (but also fails on 5.10):
>    FAIL: tests/misc/date

Ah, I was trying to demonstrate quarter is independent of year,
but specifying a year < 1900 is not portable:

solaris> src/date --date 1899-1-1
src/date: invalid date '1899-1-1'

Fix pushed.

> 
> OpenBSD 6.0:
>    FAIL: tests/tail-2/retry

This fails on all BSDs.
I moved some test cases around _after_ I verified all
the files were created in the correct order :(
I hope this addresses all those failures.

diff --git a/tests/tail-2/retry.sh b/tests/tail-2/retry.sh
index 7829923..d4988ff 100755
--- a/tests/tail-2/retry.sh
+++ b/tests/tail-2/retry.sh
@@ -148,6 +148,7 @@ returns_ 1 tail $mode --follow=descriptor missing >out 2>&1
 [ "$(countlines_)" = 2 ]         || { fail=1; cat out; }
 grep -F 'cannot open' out        || { fail=1; cat out; }
 grep -F 'no files remaining' out || { fail=1; cat out; }
+rm -f out                        || framework_failure_

 # === Test:
 # Likewise for --follow=name (without --retry).
@@ -155,6 +156,7 @@ returns_ 1 tail $mode --follow=name missing >out 2>&1 || fai
 [ "$(countlines_)" = 2 ]         || { fail=1; cat out; }
 grep -F 'cannot open' out        || { fail=1; cat out; }
 grep -F 'no files remaining' out || { fail=1; cat out; }
+rm -f out                        || framework_failure_

 # === Test:
 # Ensure that tail -F retries when the file is initially untailable.

> 
> FreeBSD-11p1:
>    FAIL: tests/misc/head-write-error
>    FAIL: tests/misc/nohup
>    FAIL: tests/misc/printenv

>    FAIL: tests/misc/printf-quote

Drats, \u0378 is deemed printable there.
Maybe that's newly assigned. I'll look into it.

>    FAIL: tests/tail-2/retry
>    FAIL: tests/tail-2/pipe-f

The new case in pipe-f seems to have binary data in 'out'.
That suggests a problem in tail(1) itself. I'll investigate.

> 
> FreeBSD 10.3:
>    FAIL: tests/misc/nohup
>    FAIL: tests/misc/printenv
>    FAIL: tests/tail-2/retry
>    FAIL: tests/tail-2/pipe-f
> 
> NetBSD 7.0.1:
>    FAIL: tests/misc/numfmt

%'f is producing grouped output in the C locale
We'll have to add a guard.

>    FAIL: tests/misc/printf-cov
>    FAIL: tests/tail-2/retry
>    FAIL: tests/cp/existing-perm-race
>    FAIL: tests/cp/file-perm-race
>    FAIL: tests/cp/parent-perm-race
>    FAIL: tests/tail-2/pipe-f
>    FAIL: tests/tail-2/pipe-f2
>    FAIL: tests/touch/not-owner

thanks Assaf!
this is a huge help

Pádraig