[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH RFC] expand: add support for incremental tab stops
From: |
Keller, Jacob E |
Subject: |
RE: [PATCH RFC] expand: add support for incremental tab stops |
Date: |
Mon, 3 Apr 2017 22:42:13 +0000 |
> -----Original Message-----
> From: Pádraig Brady [mailto:address@hidden]
> Sent: Sunday, April 02, 2017 5:05 PM
> To: Keller, Jacob E <address@hidden>; address@hidden
> Subject: Re: [PATCH RFC] expand: add support for incremental tab stops
>
> Hi Jacob,
>
> I adjusted your patch as follows:
>
> - Added NEWS, texinfo
> - Fixed/adjusted the test
> - Fixed/adjusted finalize_tab_stops() to fix bug caught by the test
> - Adjusted error handling to give more consistent errors
>
> I also adjusted the --help for both expand and unexpand,
> which I did as a separate patch (attached)
> I'll apply both of these later.
>
> thanks,
> Pádraig.
Hi,
Thanks this looks great, and I'm glad you caught a bug before we committed it.
Thanks again,
Jake