Re: [PATCH] tests: don't fail tests when failing to write here docs

[Pádraig Brady]

On 28/08/17 23:33, Bernhard Voelker wrote:
> On 08/29/2017 07:05 AM, Pádraig Brady wrote:
>> * tests/sample-test: Use framework_error_ rather than fail=1
>> * tests/chown/deref.sh: Likewise.
>> * tests/chown/preserve-root.sh: Likewise.
>> * tests/cp/src-base-dot.sh: Likewise.
>> * tests/dd/unblock-sync.sh: Likewise.
>> * tests/du/2g.sh: Likewise.
>> * tests/du/inacc-dest.sh: Likewise.
>> * tests/du/one-file-system.sh: Likewise.
>> * tests/fmt/goal-option.sh: Likewise.
>> * tests/ln/hard-backup.sh: Likewise.
>> * tests/ls/color-dtype-dir.sh: Likewise.
>> * tests/ls/m-option.sh: Likewise.
>> * tests/ls/stat-dtype.sh: Likewise.
>> * tests/ls/time-style-diag.sh: Likewise.
>> * tests/ls/x-option.sh: Likewise.
>> * tests/misc/chcon.sh: Likewise.
>> * tests/misc/nohup.sh: Likewise.
>> * tests/misc/od-N.sh: Likewise.
>> * tests/misc/sort-compress.sh: Likewise.
>> * tests/misc/tac-continue.sh: Likewise.
>> * tests/misc/time-style.sh: Likewise.
>> * tests/mv/backup-dir.sh: Likewise.
>> * tests/mv/dir2dir.sh: Likewise.
>> * tests/rm/dir-no-w.sh: Likewise.
>> * tests/rm/dir-nonrecur.sh: Likewise.
>> * tests/rm/inaccessible.sh: Likewise.
>> * tests/rm/interactive-always.sh: Likewise.
>> * tests/rm/interactive-once.sh: Likewise.
>> * tests/rm/rm3.sh: Likewise.
>> * tests/rm/v-slash.sh: Likewise.
>> * tests/touch/relative.sh: Likewise.
> 
> Nice work, thanks.
> 
> BTW: doesn't this not only apply to here documents, but also
> to many more of the commands creating the exp and out files?
> E.g.
>   echo LA:3456789abcdef > in || fail=1
> 
> It's a bit harder to find them all, but
>   git grep '^[ ]*echo.*||.*fail=' | grep -v ' | '
> seems to be a good start.

Cool. I fixed those up too