[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] base64: fix 'extra operand' error message
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] base64: fix 'extra operand' error message |
|
Date: |
Mon, 31 Dec 2018 04:23:25 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 28/12/18 00:57, Assaf Gordon wrote:
> Hello Berny,
>
> On 2018-12-21 12:32 a.m., Bernhard Voelker wrote:
>> Still, I think a user-visible fix, so I'd squash in something like:
> [...]
>> thus I suggest:
>>
>> - Subject: [PATCH] base64: fix 'extra operand' error message
>> + Subject: [PATCH] base32,base64: fix 'extra operand' error message
> [...]
>
>> FWIW: 'src/base64.c' should mention 'base32' in its title line.
>> Maybe in a separate patch (below)?
>
> All good suggestions.
>
> Please see the attached updated patch (containing two commits: the
> extra-op fix and your second patch), rebased against the latest git
> master.
Both patches look good.
thanks,
Pádraig