[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add slice by 8 algorithm to cksum to make it faster.
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] Add slice by 8 algorithm to cksum to make it faster. |
Date: |
Sat, 26 Dec 2020 22:54:14 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 |
On 26/12/2020 13:53, Kristoffer Brånemyr via GNU coreutils General Discussion
wrote:
Hi,
I modified cksum to use the well known slice by 8 algorithm in the CRC
calculation, to make it faster. On my machine it is several times faster than
the unmodified cksum. It took me a while to figure out since the CRC
calculation in cksum shifts in the opposite direction than most other
implementations I've seen. I would be glad if someone could check this patch on
a big endian machine to see if it produces the correct output! It think it
might, but not sure.
You can see the patch here:
https://github.com/coreutils/coreutils/pull/43
Thanks for the patch!
I wouldn't focus on big endian perf,
but I will test on a SPARC-Enterprise-T5220 system I have access to.
I would explicitly depend on byteswap in bootstrap.conf now,
rather than relying on the transitive dependency through md5sum etc.
cheers,
Pádraig