Re: coreutils-9.4.170-7b206 cp/preserve-mode test failure

[Pádraig Brady]

On 24/03/2024 16:42, Bruno Haible wrote:
> The cp/preserve-mode test fails on Alpine Linux 3.18.
>
> test-suite.log from Alpine Linux 3.18:
>
>
> FAIL: tests/cp/preserve-mode
> ============================

> + mkdir d1 d2
> + chmod 705 d2
> + cp '--no-preserve=mode' -r d2 d3
> + get_mode d1
> + stat '-c%f' d1
> + get_mode d3
> + stat '-c%f' d3
> + test 45ed '=' 41ed
> + fail=1

This is another setgid issue, and looks like a real bug.
It was there since 8.20 (2012) it seems.
cp is not maintaining the setgid bit, that mkdir(2) created.
I can't repro on my Fedora system, but can on Alpine,
where set_acl() falls back to a chmod because it can't set ACLs.
The attached fixes this by including the setgid bit
in the fallback mode if appropriate.

cheers,
Pádraig

cp-dir-setgid.patch
Description: Text Data