|
From: | Pádraig Brady |
Subject: | Re: coreutils-9.4.170-7b206 ls/removed-directory test failure |
Date: | Tue, 26 Mar 2024 17:35:30 +0000 |
User-agent: | Mozilla Thunderbird |
On 26/03/2024 17:08, Paul Eggert wrote:
On 3/26/24 10:50, Pádraig Brady wrote:It seems that readdir() on FreeBSD 14 is _not_ eating the ENOENT from getdirentries(). Attached is an extra check for that, that avoids the test in that case. An alternative would be for ls to ignore the ENOENT from readdir(). Paul what do you think?My quick reaction is that your patch is good. This is an area where the FreeBSD behavior is reasonable and when coreutils is in Rome we might as well do what the Romans do.
Right. Actually the FreeBSD system ls(1) does _not_ show the error in this case (it doesn't use readdir I think). So I'm not leaning towards GNU ls just eating the ENOENT which simplifies the test and makes both ls implementations behave the same in this regard. cheers, Pádraig
[Prev in Thread] | Current Thread | [Next in Thread] |