Re: NSPredicate test : build fail

[Niels Grewe]

Hi Bertrand!

> Am 11.03.2016 um 12:16 schrieb Bertrand Dekoninck 
> <bertrand.dekoninck@gmail.com>:
> 
> Hi everyone !
> 
> I tried this morning to recompile latest base and gui on debian-jessie 
> x86-32bit, with clang/objc2.
> 
> Make check fails with several errors. 
> I've got a lot of network related failed tests because I'm behin an 
> enterprise firewall and don't have internet acces in the terminal. I think it 
> maybe not a big deal.
> 
> 
> To my surprise, it even fails to build some tests : 
> 
> base/headers/NSComparisonPredicate.m:
> Failed build:
> 
> base/headers/NSCompoundPredicate.m:
> Failed build:
> 
> base/headers/NSPredicate.m:
> Failed build:
> 
> See the attached extract of the log error.
> 
> I've got the same error with a snapshot of base downloaded yertersday before 
> the last commit on base.
> 
> 
> GUI failes to build at all, with an error related to NSPredicate :
> 
>  Compiling file NSObjectController.m ...
> In file included from NSObjectController.m:31:
> /GNUstep/System/Library/Headers/Foundation/NSPredicate.h:41:82: error: type
>       argument 'NSString *' does not satisfy the bound ('id<NSCopying>') of 
> type
>       parameter 'KeyT'
>   ...BOOL, id, GS_GENERIC_CLASS(NSDictionary,NSString*,id)*);
>                                              ^
> /GNUstep/System/Library/Headers/Foundation/NSDictionary.h:41:15: note: type
>       parameter 'KeyT' declared here
>   __covariant KeyT:id<NSCopying>, __covariant ValT)
>               ^

…

> Is this local or is it broken ?

Sorry, that was an include problem I introduced when I implemented the 
+predicateWithBlock: method 
on NSPredicate: The NSPredicate header didn’t include NSString.h, so it didn’t 
know about NSString
conforming to NSCopying, hence the compiler complained about the generics bound 
not being satisfied. 
(And I only run the NSPredicate-specific tests prior to committing, sorry). It 
should be fixed in r 39527.

Cheers,

Niels