dolibarr-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Dolibarr-dev] Renaming getNomUrl


From: Christophe Battarel
Subject: Re: [Dolibarr-dev] Renaming getNomUrl
Date: Mon, 13 Oct 2014 17:40:44 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2

Hello,

I agree with you for the getObjectUrl function name.

BUT i really hope that the old getNomUrl function will still remains for compatibility with all the external modules that use it !!!
(of course this old function should become just a call to the new one)

My two cents
Christophe

Le 13/10/2014 17:30, Marcos García a écrit :
Hi all:

Alexandre Spangaro (aspangaro) did a PR (https://github.com/Dolibarr/dolibarr/pull/1936#issuecomment-58801858) where some parts of the code got renamed and therefore translated to English.

I saw he translated getNomUrl function to getNameUrl, but then I thought a more appropiate name would be getObjectUrl, as we are geting the url of the object, not of the name.

What do you think?

Regards,
 
Marcos García
address@hidden


_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


-- 
Christophe Battarel
Responsable technique
sarl altairis
Informatique et Web en Grésivaudan
33 Grande Rue
38570 Goncelin
09 52 71 70 96 (appel local)
address@hidden
http://www.altairis.fr 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]