bug#46337: closed (A patch to enable building proprietary codecs in qtwebengine)

[GNU bug Tracking System]

Your message dated Mon, 7 Jun 2021 17:01:06 -0400
with message-id <YL6JEuNVGWQfBcKx@jasmine.lan>
and subject line Re: [bug#46337] Attempt to fix the build
has caused the debbugs.gnu.org bug report #46337,
regarding A patch to enable building proprietary codecs in qtwebengine
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46337: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46337
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> A patch to enable building proprietary codecs in qtwebengine
>
>
>
>
> Date: 
>
> Sat, 6 Feb 2021 01:47:48 +0000
>
>
>
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 4fbb157600..057644a576 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -1939,7 +1939,8 @@ using the Enchant spell-checking library.")
>                         "--webengine-printing-and-pdf=no"
>                         "--webengine-ffmpeg=system"
>                         "--webengine-icu=system"
> -                       "--webengine-pepper-plugins=no")))))
> +                       "--webengine-pepper-plugins=no"
> +                      "-webengine-proprietary-codecs")))))
>         ;; Tests are disabled due to "Could not find QtWebEngineProcess
> error" ;; It's possible this can be fixed by setting
> QTWEBENGINEPROCESS_PATH ;; before running tests.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#46337] Attempt to fix the build
>
>
>
>
> Date: 
>
> Mon, 7 Jun 2021 17:01:06 -0400
>
>
>
>
> On Sun, May 30, 2021 at 07:54:33PM +0200, Sergey Trofimov wrote:
> > 
> > Hey there, it seems that qtwebengine build script just lacks the
> > `-system-openh264` flag.
> > In attempt to fix that I just slap the needed GN arg to the end of
> > `src/buildtools/config/linux.pri`
> > I've checked that the configure phase succeeds, but the full build takes too
> > long on my machine.
> > 
> > Please find attached the proposed patch.
> > 
>
> > From 553a37f4af401f2a53575c0f2d77cb5030344f40 Mon Sep 17 00:00:00 2001
> > From: Sergey Trofimov <sarg@sarg.org.ru>
> > Date: Sun, 30 May 2021 14:39:15 +0200
> > Subject: [PATCH] qtwebengine with openh264
>
> Thanks! I wrote a commit message and pushed as
> 68dcdf6ea76cddc4f9e53aabe7c1a5724d5508b2
>
>
> --- End Message ---