bug#49054: closed (Add borg-sans-mono Font)

[GNU bug Tracking System]

Your message dated Sat, 19 Jun 2021 19:38:47 +0200
with message-id 
<b8c68baf9b2b7e1c53406bf5901c700834db9b6a.camel@student.tugraz.at>
and subject line Re: Add borg-sans-mono Font
has caused the debbugs.gnu.org bug report #49054,
regarding Add borg-sans-mono Font
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49054: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49054
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Add borg-sans-mono Font Date: Wed, 16 Jun 2021 00:53:14 +0000

This is my first contribution, so let me know if I did something wrong. The patch is attatched.

0001-gnu-Add-font-borg-sans-mono.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Add borg-sans-mono Font
>
>
>
>
> Date: 
>
> Sat, 19 Jun 2021 19:38:47 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.34.2 
>
>
>
>
> Am Samstag, den 19.06.2021, 16:33 +0000 schrieb Charles:
> > Thank you so much for reviewing my patch, and helping me correct it.
> > Attatched is an fixed version.
> I've pushed your patch with some cosmetic adjustments as listed below:
> - instead of appending the package to the end, I added it after
> Google's Roboto fonts
> - I changed the git-reference to be a two-liner
> - I changed the hash to be a three-liner as otherwise there'd be
> problems with smaller screens and you don't want those.
> - I reworded the description a little as the old one included a typo
> and to me personally didn't really get the actual idea behind the
> package across.
>
> I missed, that the commit message still didn't follow the format 100%.
> I ought to have corrected it to:
>
> gnu: Add font-borg-sans-mono.
>
> * gnu/packages/fonts.scm (font-borg-sans-mono): New variable.
>
> Anyway, you should now be able to pull and build the font :)
>
> All the best,
> Leo
> > 
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > 
> > On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler <
> > leo.prikler@student.tugraz.at> wrote:
> > 
> > > Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
> > > 
> > > > This is my first contribution, so let me know if I did something
> > > > 
> > > > wrong. The patch is attatched.
> > > > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > > > > 
> > > > > -   gnu/packages/fonts.scm (font-borg-sans-mono): Add font
> > > 
> > > Nitpicky, but the dot in the headerline is missing and we usually
> > > 
> > > denote new packages by "new variable" since that's what they are on
> > > 
> > > Scheme level.
> > > 
> > > > -   (name "font-borg-sans-mono")
> > > > -   (version "0.3.0")
> > > > -   (home-page "https://github.com/charje/borg-sans-mono";)
> > > 
> > > home-page usually comes after build-system+arguments.
> > > 
> > > > -         (uri (string-append
> > > > 
> > > > 
> > > > -               home-page
> > > > 
> > > > 
> > > > -               "/releases/download/v"
> > > > 
> > > > 
> > > > -               version
> > > > 
> > > > 
> > > > -               "/borg-sans-mono.zip"))
> > > > 
> > > > 
> > > 
> > > Please type out home-page. It could very well be, that the devs
> > > start
> > > 
> > > some fancy Github Pages website, which would break this code.
> > > 
> > > > -   (description "Droid Sans Mono Slashed + Hasklig-style
> > > > 
> > > >     ligatures!")
> > > 
> > > This is not very descriptive at all, I'm afraid. If Hasklig or
> > > Monoid
> > > 
> > > are a reasonable alternative to this font, it's probably easier to
> > > find
> > > 
> > > a description for them.
> > > 
> > > Regards,
> > > 
> > > Leo
>
>
>
> --- End Message ---