bug#49183: closed ([PATCH] gnu: ocaml-dose3: Fix tests.)

[GNU bug Tracking System]

Your message dated Wed, 23 Jun 2021 14:45:52 +0200
with message-id <20210623144552.64b67204@tachikoma.lepiller.eu>
and subject line Re: [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
has caused the debbugs.gnu.org bug report #49183,
regarding [PATCH] gnu: ocaml-dose3: Fix tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49183: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49183
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: ocaml-dose3: Fix tests.
>
>
>
>
> Date: 
>
> Wed, 23 Jun 2021 10:52:38 +0200
>
>
>
>
> * gnu/packages/ocaml.scm (ocaml-dose3)[arguments]<#:phases>: Add phase to
> patch tests script.
> ---
> The test script was failing to run without this, which also caused
> emacs-tuareg to not build.
>
> No idea why one would use Python to test OCaml code...
>
>  gnu/packages/ocaml.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index dd30f4cc97..1262c0e303 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -647,7 +647,14 @@ underlying solvers like Cplex, Gurobi, Lpsolver, Glpk, 
> CbC, SCIP or WBO.")
>         #:make-flags
>         (list (string-append "LIBDIR="
>                              (assoc-ref %outputs "out")
> -                            "/lib/ocaml/site-lib"))))
> +                            "/lib/ocaml/site-lib"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-test-script
> +           (lambda _
> +             (substitute* "applications/dose-tests.py"
> +               (("warning\\(")
> +                "from warnings import warn\nwarn(")))))))
>      (propagated-inputs
>        `(("ocaml-graph" ,ocaml-graph)
>          ("ocaml-cudf" ,ocaml-cudf)
>
> base-commit: 4605ea1a780ff5889b7273d27a255294d7a08327
> -- 
> 2.32.0
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
>
>
>
>
> Date: 
>
> Wed, 23 Jun 2021 14:45:52 +0200
>
>
>
>
> Le Wed, 23 Jun 2021 11:09:44 +0000,
> pukkamustard <pukkamustard@posteo.net> a écrit :
>
> > Neat. Thanks!
> > 
> > Fixes the test and looks got to me.
> > 
> > > No idea why one would use Python to test OCaml code...  
> >  
> > Yeah, makes one wonder. At least they've updated to Python3 
> > (https://gitlab.com/irill/dose3/-/blob/master/CHANGES#L33) 
> > recently.
> > 
> > 
> > 
>
> Thanks! Pushed as 91b29aa37394b660117e1d79927621db1344b7fe.
>
>
> --- End Message ---