bug#53249: closed (Context menu in other window)

[GNU bug Tracking System]

Your message dated Sat, 15 Jan 2022 20:38:11 +0200
with message-id <86k0f03kvg.fsf@mail.linkov.net>
and subject line Re: bug#53249: Context menu in other window
has caused the debbugs.gnu.org bug report #53249,
regarding Context menu in other window
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53249: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53249
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Context menu in other window
>
>
>
>
> Date: 
>
> Fri, 14 Jan 2022 10:42:43 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> When clicking the right mouse button in another window,
> some context-menu functions break the window configuration.
> For example, when two windows show different parts of the same buffer,
> this code in `prog-context-menu':
>
>   (let ((identifier (save-excursion
>                       (mouse-set-point click)
>                       (xref-backend-identifier-at-point
>                        (xref-find-backend)))))
>
> moves window point of another window to the same position of the
> selected window.
>
> So the safest thing to do here is to select the window where
> the context menu is invoked:
>
> diff --git a/lisp/mouse.el b/lisp/mouse.el
> index 0d8d7d6175..45b7d51da7 100644
> --- a/lisp/mouse.el
> +++ b/lisp/mouse.el
> @@ -320,6 +320,8 @@ context-menu-map
>           (fun (mouse-posn-property (event-start click)
>                                     'context-menu-function)))
>  
> +    (select-window (posn-window (event-start click)))
> +
>      (if (functionp fun)
>          (setq menu (funcall fun menu click))
>        (run-hook-wrapped 'context-menu-functions
> -- 
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53249: Context menu in other window
>
>
>
>
> Date: 
>
> Sat, 15 Jan 2022 20:38:11 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> >> So the safest thing to do here is to select the window where
> >> the context menu is invoked:
> >
> > Makes sense to me.
>
> So pushed to master and closed.
>
>
> --- End Message ---