emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#54572: closed ([PATCH] gnu: solfege: Remove trailing booleans.)


From: GNU bug Tracking System
Subject: bug#54572: closed ([PATCH] gnu: solfege: Remove trailing booleans.)
Date: Tue, 29 Mar 2022 08:58:01 +0000

Your message dated Tue, 29 Mar 2022 10:57:29 +0200
with message-id <87ilrx6squ.fsf_-_@gnu.org>
and subject line Re: bug#54572: [PATCH] gnu: solfege: Remove trailing booleans.
has caused the debbugs.gnu.org bug report #54572,
regarding [PATCH] gnu: solfege: Remove trailing booleans.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54572
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] gnu: solfege: Remove trailing booleans. Date: Fri, 25 Mar 2022 21:15:38 -0400
* gnu/packages/music.scm (solfege): Remove trailing booleans.
---
 gnu/packages/music.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2c6b530aac..d7f0c0d39d 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2058,16 +2058,14 @@ (define-public solfege
                (("/usr/bin/aplay") "aplay")
                (("/usr/bin/timidity") "timidity")
                (("/usr/bin/mpg123") "mpg123")
-               (("/usr/bin/ogg123") "ogg123"))
-             #t))
+               (("/usr/bin/ogg123") "ogg123"))))
          (add-before 'build 'patch-python-shebangs
            (lambda _
              ;; Two python scripts begin with a Unicode BOM, so patch-shebang
              ;; has no effect.
              (substitute* '("solfege/parsetree.py"
                             "solfege/presetup.py")
-               (("#!/usr/bin/python") (string-append "#!" (which "python"))))
-             #t))
+               (("#!/usr/bin/python") (string-append "#!" (which "python"))))))
          (add-before 'build 'add-sitedirs
            ;; .pth files are not automatically interpreted unless the
            ;; directories containing them are added as "sites".  The 
directories
-- 
2.34.0




--- End Message ---
--- Begin Message --- Subject: Re: bug#54572: [PATCH] gnu: solfege: Remove trailing booleans. Date: Tue, 29 Mar 2022 10:57:29 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hey,

> Questionable uses of which.
>
> It'd also be nice if you could update arguments to be a list of G-
> expressions and do all the other modernizations.

That can come in a follow-up patch, pushed that one in the meantime.

Thanks,

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]