--- Begin Message ---
|
Subject: |
Building from git breaks when /bin/sh isn't bash |
|
Date: |
Wed, 15 Apr 2020 18:06:25 +0900 |
|
User-agent: |
mblaze/0.5.1 |
When building from git, ./bootstrap ends up generating (via automake) several
Makefiles that set SHELL = /bin/sh. However, some targets contain rules that
make use of bashisms. This leads to breakage when /bin/sh is something other
than bash.
In particular, I am building from a foreign distro which links /bin/sh to dash.
Currently, this ends up breaking the build, the details of which I reported
to guix-devel in [0].
As a workaround, at the moment we have to force make's SHELL to point to bash.
The cleanest way to do this is probably as follows:
$ make SHELL=$(command -v sh)
since from within guix environment --pure guix, sh ends up pointing to bash.
Just for clarity, here is how this looks for me, currently:
$ git rev-parse HEAD
2708ae3d69b54d8323ca84fd9a7fb108a6ee96ba
$ guix environment --pure guix
$ readlink -f $(command -v sh)
/gnu/store/29jhbbg1hf557x8j53f9sxd9imlmf02a-bash-minimal-5.0.7/bin/bash
[0]:https://lists.gnu.org/archive/html/guix-devel/2020-04/msg00232.html
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#40641: Building from git breaks when /bin/sh isn't bash |
|
Date: |
Thu, 07 Jul 2022 17:52:24 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hello,
elaexuotee@wilsonb.com writes:
> "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
>> Thank you for getting back to the bug. I am in the same situation in
>> that I use Guix System now. :D
>>
>> On Tue, Jun 21, 2022 at 09:20:28AM +0900, elaexuotee@wilsonb.com wrote:
>> > so you could be able to sanity
>> > check with something like
>> >
>> > $ guix shell -C dash guix make <etc>
>> > $ ln -s $(command -v dash) /bin/sh
>> > $ ./configure --localstatedir && make
>>
>> I had done exactly this.
>>
>> guix shell --container --network dash git pkg-config gnutls guile
>> guile-avahi guile-gcrypt guile-json guile-lib guile-sqlite3
>> guile-zlib guile-lzlib guile-zstd guile-ssh guile-git autoconf
>> automake gettext texinfo graphviz help2man po4a findutils sed
>> coreutils tar xz m4 diffutils grep gcc-toolchain sqlite libgcrypt
>> gawk make glibc-locales -- dash
>>
>> Many tests fail because of the container though, so I’m not sure how
>> big the effect is. At least tests/guix-package.sh still use type -P
>> which is not POSIX, but I don’t think it should be changed nor should
>> there be a check if $SHELL can do what we need, because we don’t know
>> which bash features we need.
>
> Excellent. I agree it's probably not worth POSIXifying the scripts. Forcing
> make to default to guix's bash seems like the right approach IMHO, so +1 for
> that fix.
>
> FWIW, I ended up working around the original issue by explicitly telling make
> to use guix's bash, anyway:
>
> $ guix environment guix bash
> $ CONFIG_SHELL=$(command -v bash) ./configure --localstatedir=/var
OK. Good to know, glad it can be easily worked around.
Closing.
Maxim
--- End Message ---