--- Begin Message ---
|
Subject: |
[PATCH 6/9] gnu: Add node-pbf. |
|
Date: |
Tue, 14 Jun 2022 11:49:51 +0200 |
* gnu/packages/node-xyz.scm (node-pbf): New variable.
---
gnu/packages/node-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm
index 3d945871cd..aa838108ad 100644
--- a/gnu/packages/node-xyz.scm
+++ b/gnu/packages/node-xyz.scm
@@ -233,6 +233,41 @@ (define-public node-oop
while being as light-weight and simple as possible.")
(license license:expat))))
+(define-public node-pbf
+ (package
+ (name "node-pbf")
+ (version "3.2.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/mapbox/pbf";)
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1r8xs787ix79yr0vrwrizdml9h7cmxjrzhvnhkj784ac5f8nv5j7"))))
+ (build-system node-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (delete 'check)
+ (replace 'configure
+ (lambda* (#:key inputs #:allow-other-keys)
+ (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
+ "--offline" "--ignore-scripts" "install" "--production")
+ #t)))))
+ (inputs (list node-ieee754 node-resolve-protobuf-schema))
+ (home-page "https://github.com/mapbox/pbf";)
+ (synopsis "Low-level library for decoding and encodingprotocol buffers in
+Javascript")
+ (description "This package is a low-level, fast, ultra-lightweight (3KB
+gzipped) JavaScript library for decoding and encoding protocol buffers, a
+compact binary format for structured data serialization. Works both in Node and
+the browser. Supports lazy decoding and detailed customization of the
+reading/writing code.")
+ (license license:bsd-3)))
+
(define-public node-protocol-buffers-schema
(package
(name "node-protocol-buffers-schema")
--
2.36.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: Updated series |
|
Date: |
Wed, 20 Jul 2022 17:16:48 +0200 |
Nicolas Graves <ngraves@ngraves.fr> skriver:
> Hi Marius,
>
> Sorry for the time it took me, here's the updated series.
No worries, thanks a lot for this work.
> Everything has been checked with guix lint. I use emacs, but couldn't get guix
> style to work the way you counselled, hope it's ok.
What was the issue? :-)
I ran 'guix style' for each since I had to edit the commits anyway to
get the author right (for some reason it showed up as "Nicolas Graves
via Guix-patches <guix-patches@gnu.org>" -- NYF!).
> Also thanks for your advice!
:-)
Some more advice for future pull requests, please first send a message
to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything,
although often a 'git format-patch --cover-letter'). Then send the
patch series to NNNNN@debbugs.gnu.org, otherwise the patches will
be scattered across different issues and difficult to track.
Also, use "-n" with send-email/format-patch so that the ordering is
preserved. It was lacking in the second series, but I used the
information from the first round to get it right.
Anyway, great work, pushed as c8f33b613e..cda3de3b7d!
signature.asc
Description: PGP signature
--- End Message ---