--- Begin Message ---
|
Subject: |
[PATCH] Recognize defstruct slot names in various eieio functions |
|
Date: |
Thu, 20 Apr 2023 00:15:50 +0200 |
The function `eieio--known-slot-name-p' is used by some eieio functions
(specifically eieio-oref, eieio-oref-default, and eieio-oset-default) to
check whether a slot name is known or not, and if not signals an
"Unknown slot" warning.
Structs do not make their slots known to `eieio--known-slot-name-p', so
the warning is signaled even for valid slot names. Since eieio aims for
compatibility with defstruct, this should probably be considered a bug.
The function `eieio--known-slot-name-p' checks the variable
`eieio--known-slot-names' but also has a fallback for the name's
`slot-name' property. In the patch I opted to use the latter.
0001-Recognize-defstruct-slot-names-in-various-eieio-func.patch
Description: The patch
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions |
|
Date: |
Wed, 03 May 2023 14:47:10 +0300 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Thuna <thuna.cing@gmail.com>, 62959@debbugs.gnu.org
> Date: Tue, 02 May 2023 16:48:02 -0400
>
> >> diff --git a/lisp/emacs-lisp/cl-preloaded.el
> >> b/lisp/emacs-lisp/cl-preloaded.el
> >> index 9445093f143..5235be52996 100644
> >> --- a/lisp/emacs-lisp/cl-preloaded.el
> >> +++ b/lisp/emacs-lisp/cl-preloaded.el
> >> @@ -176,6 +176,7 @@ cl-struct-define
> >> (i 0)
> >> (offset (if type 0 1)))
> >> (dolist (slot slots)
> >> + (put (car slot) 'slot-name t)
> >> (let* ((props (cl--plist-to-alist (cddr slot)))
> >> (typep (assq :type props))
> >> (type (if (null typep) t
> >> --
> >> 2.39.2
> >>
> >
> > Stefan, any comments?
>
> LGTM, thanks,
Thanks, installed on the emacs-29 branch, and closing.
--- End Message ---