emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#63261: closed (Recent changes to git config cause errors for non-com


From: GNU bug Tracking System
Subject: bug#63261: closed (Recent changes to git config cause errors for non-committers)
Date: Sun, 07 May 2023 03:35:02 +0000

Your message dated Sat, 06 May 2023 23:34:42 -0400
with message-id <87y1m024rx.fsf@gmail.com>
and subject line Re: bug#63261: Recent changes to git config cause errors for 
non-committers
has caused the debbugs.gnu.org bug report #63261,
regarding Recent changes to git config cause errors for non-committers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63261: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63261
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Recent changes to git config cause errors for non-committers Date: Thu, 04 May 2023 06:47:32 -0400 User-agent: mu4e 1.10.2; emacs 28.2

I've run into two issues with the recent changes to git config integration:

1) All commits must now be signed, even if you're not a committer. This breaks just tons of things, including rebasing. I'm not sure how to fix this without just disabling that configuration line altogether.

2) Some ‘make’ rules now require git to be installed so that ‘git config’ can add ‘etc/git/gitconfig’ to the local configuration. So, for instance, ‘guix shell --pure -D guix -- make’ will now fail. Calls to git should be prefixed with a test to see if there is a git executable in the path.

-bjc



--- End Message ---
--- Begin Message --- Subject: Re: bug#63261: Recent changes to git config cause errors for non-committers Date: Sat, 06 May 2023 23:34:42 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Hi,

Brian Cully via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

> I've run into two issues with the recent changes to git config
> integration:
>
> 1) All commits must now be signed, even if you're not a
> committer. This breaks just tons of things, including rebasing. I'm
> not sure how to fix this without just disabling that configuration
> line altogether.
>
> 2) Some ‘make’ rules now require git to be installed so that ‘git
> config’ can add ‘etc/git/gitconfig’ to the local configuration. So,
> for instance, ‘guix shell --pure -D guix -- make’ will now fail. Calls
> to git should be prefixed with a test to see if there is a git
> executable in the path.

2. has been fixed (also by Ludovic, ah!).  I'm not sure a good solution
can be found for 1. but it seems reasonable to me that contributors
working on Guix learn to sign their commits with GnuPG; that way they
are on the right path to become a Guix committer, already getting up to
speed with the required practices.

Closing, but we can continue discussing it.

-- 
Thanks,
Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]