bug#61320: closed (28.2; `vc-cvs-parse-root' returns wrong results)

[GNU bug Tracking System]

Your message dated Sat, 13 May 2023 09:04:22 +0300
with message-id <838rdsbwd5.fsf@gnu.org>
and subject line Re: bug#61320: `vc-cvs-parse-root' returns wrong results
has caused the debbugs.gnu.org bug report #61320,
regarding 28.2; `vc-cvs-parse-root' returns wrong results
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61320: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61320
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 28.2; `vc-cvs-parse-root' returns wrong results
>
>
>
>
> Date: 
>
> Mon, 06 Feb 2023 13:43:44 +0100
>
>
>
>
> This reproduces also in master.
>
> Not sure why nobody has reported this.  Most likely because the current
> callers of `vc-cvs-parse-root' care only about some aspects of the
> actual result of `vc-cvs-parse-root'.
>
> $ emacs -Q
>
> In scratch buffer evaluate the following (specification of Ctrl-J
> omitted for clarity):
>
> (load-library "vc-cvs")
> t
>
> ;; this one is correct in the sense that 3rd element of the list is nil
> ;; (making it a local root for `vc-cvs-repository-hostname'), but
> ;; probably is not what the author has intended:
> (vc-cvs-parse-root ":local:/var/lib/cvs")
> ("local" nil nil "var:/lib/cvs")
>
> ;; but this one is completely broken:
> (vc-cvs-parse-root "/var/lib/cvs")
> ("ext" nil "var" "/lib/cvs")
>
> There might be different fixes, but IMHO the regexp used in function
> `vc-cvs-parse-uhp' should be anchored to beginning of line or string:
>
>   "\\`\\([^/]+\\)\\(/.*\\)"
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61320: `vc-cvs-parse-root' returns wrong results
>
>
>
>
> Date: 
>
> Sat, 13 May 2023 09:04:22 +0300
>
>
>
>
> > Date: Fri, 12 May 2023 22:48:46 +0200
> > From:  Farblos via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> > 
> > Fixed in master:
> > 
> > M-x emacs-version RET
> > 
> > GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
> > cairo version 1.16.0) of 2023-05-12
> > 
> > (vc-cvs-parse-root ":local:/var/lib/cvs")
> > ("local" nil nil "/var/lib/cvs")
> > 
> > (vc-cvs-parse-root "/var/lib/cvs")
> > ("local" nil nil "/var/lib/cvs")
> > 
> > Feel free to close this issue.
>
> Thanks, done.
>
>
> --- End Message ---