bug#63740: closed (broken and questionable attribute normalisation in xml.el)

[GNU bug Tracking System]

Your message dated Tue, 30 May 2023 17:50:01 +0200
with message-id <58A527AB-79B2-4E11-9049-35049F1EA417@acm.org>
and subject line bug#63740: broken and questionable attribute normalisation in 
xml.el
has caused the debbugs.gnu.org bug report #63740,
regarding broken and questionable attribute normalisation in xml.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63740: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63740
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> broken and questionable attribute normalisation in xml.el
>
>
>
>
> Date: 
>
> Fri, 26 May 2023 17:14:53 +0200
>
>
>
>
> In `xml-parse-attlist`, we see:
>
>       ;; Multiple whitespace characters should be replaced with a single one
>       ;; in the attributes
>       (let ((string (match-string-no-properties 1)))
>         (replace-regexp-in-string "\\s-\\{2,\\}" " " string)
>         ...
>
> The call to `replace-regexp-in-string` is of course useless and there is now a 
> compiler warning telling us, which is how this came to light.
>
> However, should we really collapse whitespace here? If I'm reading the spec 
> correctly, it's not done for CDATA attributes and we have no reason to believe 
> any other type, do we?
>
> I'm no XML expert but it looks like the code is correct and we can just remove 
> the call to `replace-regexp-in-string` (and the misleading comment). Or?
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> bug#63740: broken and questionable attribute normalisation in xml.el
>
>
>
>
> Date: 
>
> Tue, 30 May 2023 17:50:01 +0200
>
>
>
>
> I decided that the attempt to collapse whitespace in attributes is wrong and 
> removed the ineffective attempt to do so in 9ae212fb1e. Bug closed.
>
>
>
> --- End Message ---