bug#65336: closed ([PATCH 0/2] Update looking-glass-client to B6 and restyle package)

[GNU bug Tracking System]

Your message dated Tue, 29 Aug 2023 14:05:06 +0100
with message-id <875y4ygfrr.fsf@cbaines.net>
and subject line Re: [bug#65336] [PATCH 0/2] Update looking-glass-client to B6 
and restyle package
has caused the debbugs.gnu.org bug report #65336,
regarding [PATCH 0/2] Update looking-glass-client to B6 and restyle package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
65336: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65336
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Update looking-glass-client to B6 and restyle package
>
>
>
>
> Date: 
>
> Wed, 16 Aug 2023 13:15:49 +0400
>
>
>
>
> Hello Guix,
>
> This series updates and restyles looking-glass-client, and also restores a
> configuration parameter that was dropped in the previous update patch. Some
> notes for posterity below.
>
> The package builds with "-march=native" GCC parameter by default, which
> makes it incompatible with CPUs older than the build machine and causes
> crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
> others. We build it with the minimum supported CPU architecture to fix that.
> This also helps with package reproducibility.
>
> Thanks,
>
> Ahmad Draidi (2):
>   gnu: looking-glass-client: Update to B6.
>   gnu: looking-glass-client: Update package style.
>
>  gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
>  1 file changed, 73 insertions(+), 73 deletions(-)
>
>
> base-commit: 880ada0bdb9e694573ec42200d48658b27744b9b
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#65336] [PATCH 0/2] Update looking-glass-client to B6 and restyle package Date: Tue, 29 Aug 2023 14:05:06 +0100 User-agent: mu4e 1.10.5; emacs 28.2

Ahmad Draidi via Guix-patches via <guix-patches@gnu.org> writes:

> This series updates and restyles looking-glass-client, and also restores a
> configuration parameter that was dropped in the previous update patch. Some
> notes for posterity below.
>
> The package builds with "-march=native" GCC parameter by default, which
> makes it incompatible with CPUs older than the build machine and causes
> crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
> others. We build it with the minimum supported CPU architecture to fix that.
> This also helps with package reproducibility.
>
> Thanks,
>
> Ahmad Draidi (2):
>   gnu: looking-glass-client: Update to B6.
>   gnu: looking-glass-client: Update package style.
>
>  gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
>  1 file changed, 73 insertions(+), 73 deletions(-)

Thanks Ahmad, these changes look good to me. I've pushed to master as
02e32197a80e4fc323ffe0e519ad4e58f206fc5d.

signature.asc
Description: PGP signature

--- End Message ---