emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#66911: closed (CC Mode 5.35.2 (C++//l); Noise macro being taken as a


From: GNU bug Tracking System
Subject: bug#66911: closed (CC Mode 5.35.2 (C++//l); Noise macro being taken as anchor to class-open)
Date: Fri, 24 Nov 2023 10:15:03 +0000

Your message dated Fri, 24 Nov 2023 10:14:45 +0000
with message-id <ZWB3lYys4ZPnpQ4A@ACM>
and subject line Re: bug#66911: CC Mode 5.35.2 (C++//l); Noise macro being 
taken as anchor to class-open
has caused the debbugs.gnu.org bug report #66911,
regarding CC Mode 5.35.2 (C++//l); Noise macro being taken as anchor to 
class-open
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66911: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66911
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: CC Mode 5.35.2 (C++//l); Noise macro being taken as anchor to class-open Date: Fri, 03 Nov 2023 10:51:32 +0100
Package: cc-mode

<#secure method=pgpmime mode=sign>
Package: cc-mode

In the example below:

namespace a {
_BEGIN

  template<>
    struct foo
    { /* HERE */
    };
}

// Local Variables:
// c-noise-macro-names: ("_BEGIN")
// End:

Pressing C-c C-s on the stat of the line marked HERE shows ((class-open
15)), which is the '_' of the '_BEGIN'.  This appears to be wrong, as
the anchor should be the 'class' keyword on the line above, I believe.

Anchoring '{' on the class/struct/union that precedes it would also
enable implementing the GNU libstdc++ code style (as, AFAICT, it is
currently impossible to indent a class with a basic-offset added to the
column the 'template' keyword sits on).

Emacs  : GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, 
cairo version 1.17.8)
 of 2023-09-24
Package: CC Mode 5.35.2 (C++//l)
Buffer Style: gnu
c-emacs-features: (pps-extended-state col-0-paren posix-char-classes 
gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

current state:
==============
(setq
 c-basic-offset 2
 c-comment-only-line-offset '(0 . 0)
 c-indent-comment-alist '((anchored-comment column . 0) (end-block space . 1)
                          (cpp-end-block space . 2))
 c-indent-comments-syntactically-p nil
 c-block-comment-prefix ""
 c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+")
                           (other . "//+\\|\\**"))
 c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode
 . gtkdoc)
                       (c++-mode . gtkdoc))
 c-cleanup-list '(scope-operator)
 c-hanging-braces-alist '((substatement-open before after) 
(arglist-cont-nonempty))
 c-hanging-colons-alist nil
 c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist)
 c-backslash-column 48
 c-backslash-max-column 72
 c-special-indent-hook '(t c-gnu-impose-minimum)
 c-label-minimum-indentation 1
 c-offsets-alist '((inexpr-class . +)
                   (inexpr-statement . +)
                   (lambda-intro-cont . +)
                   (inlambda . 0)
                   (template-args-cont
                    c-lineup-template-args
                    c-lineup-template-args-indented-from-margin
                    )
                   (incomposition . +)
                   (inmodule . +)
                   (innamespace . +)
                   (inextern-lang . +)
                   (composition-close . 0)
                   (module-close . 0)
                   (namespace-close . 0)
                   (extern-lang-close . 0)
                   (composition-open . 0)
                   (module-open . 0)
                   (namespace-open . 0)
                   (extern-lang-open . 0)
                   (objc-method-call-cont
                    c-lineup-ObjC-method-call-colons
                    c-lineup-ObjC-method-call
                    +
                    )
                   (objc-method-args-cont . c-lineup-ObjC-method-args)
                   (objc-method-intro . [0])
                   (friend . 0)
                   (cpp-define-intro c-lineup-cpp-define +)
                   (cpp-macro-cont . +)
                   (cpp-macro . [0])
                   (inclass . +)
                   (stream-op . c-lineup-streamop)
                   (arglist-cont-nonempty c-lineup-gcc-asm-reg
 c-lineup-arglist)
                   (arglist-cont c-lineup-gcc-asm-reg 0)
                   (comment-intro c-lineup-knr-region-comment c-lineup-comment)
                   (catch-clause . 0)
                   (else-clause . 0)
                   (do-while-closure . 0)
                   (access-label . -)
                   (case-label . 0)
                   (substatement . +)
                   (statement-case-intro . +)
                   (statement . 0)
                   (brace-entry-open . 0)
                   (brace-list-entry . 0)
                   (brace-list-close . 0)
                   (block-close . 0)
                   (block-open . 0)
                   (inher-cont . c-lineup-multi-inher)
                   (inher-intro . +)
                   (member-init-cont . c-lineup-multi-inher)
                   (member-init-intro . +)
                   (annotation-var-cont . +)
                   (annotation-top-cont . 0)
                   (constraint-cont . +)
                   (topmost-intro . 0)
                   (knr-argdecl . 0)
                   (func-decl-cont . +)
                   (inline-close . 0)
                   (class-close . 0)
                   (class-open . 0)
                   (defun-block-intro . +)
                   (defun-close . 0)
                   (defun-open . 0)
                   (c . c-lineup-C-comments)
                   (string . c-lineup-dont-change)
                   (topmost-intro-cont
                    first
                    c-lineup-topmost-intro-cont
                    c-lineup-gnu-DEFUN-intro-cont
                    )
                   (brace-list-intro
                    first
                    c-lineup-2nd-brace-entry-in-arglist
                    c-lineup-class-decl-init-+
                    +
                    )
                   (brace-list-open . +)
                   (inline-open . 0)
                   (arglist-close . c-lineup-arglist)
                   (arglist-intro . c-lineup-arglist-intro-after-paren)
                   (statement-cont . +)
                   (statement-case-open . +)
                   (label . 0)
                   (substatement-label . 0)
                   (substatement-open . +)
                   (knr-argdecl-intro . 5)
                   (statement-block-intro . +)
                   )
 c-buffer-is-cc-mode 'c++-mode
 c-tab-always-indent t
 c-syntactic-indentation t
 c-syntactic-indentation-in-macros t
 c-ignore-auto-fill '(string cpp code)
 c-auto-align-backslashes t
 c-backspace-function 'backward-delete-char-untabify
 c-delete-function 'delete-char
 c-electric-pound-behavior nil
 c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu"))
 c-enable-xemacs-performance-kludge-p nil
 c-old-style-variable-behavior nil
 defun-prompt-regexp nil
 tab-width 8
 comment-column 32
 parse-sexp-ignore-comments t
 parse-sexp-lookup-properties t
 auto-fill-function 'c-do-auto-fill
 comment-multi-line t
 comment-start-skip "\\(?://+\\|/\\*+\\)\\s *"
 fill-prefix nil
 fill-column 79
 paragraph-start "[     ]*\\(//+\\|\\**\\)[     ]*$\\|^\f"
 adaptive-fill-mode t
 adaptive-fill-regexp "[        ]*\\(//+\\|\\**\\)[     ]*\\([  
]*\\([-–!|#%;>*·•‣⁃◦]+[         ]*\\)*\\)"
 )

-- 
Arsen Arsenović



--- End Message ---
--- Begin Message --- Subject: Re: bug#66911: CC Mode 5.35.2 (C++//l); Noise macro being taken as anchor to class-open Date: Fri, 24 Nov 2023 10:14:45 +0000
Hello, Arsen.

On Fri, Nov 17, 2023 at 20:17:47 +0000, Alan Mackenzie wrote:
> On Fri, Nov 17, 2023 at 20:16:31 +0100, Arsen Arsenović wrote:
> > Hi Alan,

[ .... ]

> > > So, please try out the new patch (below) which supplies the second anchor
> > > point to class-close too.  The patch applies cleanly to the Emacs master
> > > branch.  Again, please start off with a clean cc-engine.el before
> > > applying the new patch, not the version with the previous patch applied.

[ .... ]

> > In any case, I'll be sure to use this as soon as it lands in the Emacs
> > VCS.

> This might take a few days - I've still got to amend the (stand alone CC
> Mode) test suite and the documentation.  And I've got quite a lot on in
> Real Life in the next few days.

I've now amended the test suite and cc-mode.texi.  I've committed the
enhancement to all the usual places, including the Emacs master branch,
so I'm closing the bug with this post.

> > -- 
> > Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]