bug#66114: closed ([PATCH] Fix interactive prompt for selecting checkout directory)

[GNU bug Tracking System]

Your message dated Wed, 14 Feb 2024 16:54:15 +0000
with message-id <87eddfgf60.fsf@posteo.net>
and subject line Re: bug#66114: [PATCH] Fix interactive prompt for selecting 
checkout directory
has caused the debbugs.gnu.org bug report #66114,
regarding [PATCH] Fix interactive prompt for selecting checkout directory
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66114: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66114
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix interactive prompt for selecting checkout directory Date: Wed, 20 Sep 2023 00:02:43 -0700

Tags: patch

This patch fixes the interactive prompt in package-vc-checkout. See
commit message for details.

0001-Fix-interactive-prompt-for-selecting-checkout-direct.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#66114: [PATCH] Fix interactive prompt for selecting checkout directory
>
>
>
>
> Date: 
>
> Wed, 14 Feb 2024 16:54:15 +0000
>
>
>
>
> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
> > Joseph Turner <joseph@breatheoutbreathe.in> writes:
> >
> >> Philip Kaludercic <philipk@posteo.net> writes:
> >>
> >>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
> >>>
> >>>>                                                  However, the behavior of
> >>>> read-file-name is unspecified when a MUSTMATCH function returns nil:
> >>>>
> >>>> - a function, which will be called with the input as the
> >>>>   argument.  If the function returns a non-nil value, the
> >>>>   minibuffer is exited with that argument as the value.
> >>>>
> >>>> Is this a bug, a case of under-documentation, or do I misunderstand 
> >>>> something?
> >>>>
> >>>> I'm happy to post this in a separate bug thread if you think it's worth it.
> >>>
> >>> Perhaps that would be worth doing, that way the people who know more
> >>> about completion than I do would be more likely to see it and help
> >>> out.
> >>
> >> Okay, thanks! I'll do that.
> >
> > Now that #66187
> > (<https://yhetil.org/emacs-bugs/87cytlqmqh.fsf@breatheoutbreathe.in/>)
> > and bug#68815
> > (<https://yhetil.org/emacs-bugs/8734ufyxoy.fsf@breatheoutbreathe.in/>)
> > are fixed on emacs-29, I'm revisiting this issue.
> >
> > With the following patch, the interactive prompt in package-vc-checkout
> > now offers all directory for completion (empty or not), but only exits
> > when the minibuffer contains an empty directory or nonexistent filename.
> >
> > Testing this patch requires checking out emacs-29 after e6c82fe35e3.
>
> LGTM, I've pushed it to emacs-29.  Thanks!
>
> > Thanks!
> >
> > Joseph
>
>
> --- End Message ---