emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#69927: closed ([PATCH] Fix function vtable--recompute-numerical)


From: GNU bug Tracking System
Subject: bug#69927: closed ([PATCH] Fix function vtable--recompute-numerical)
Date: Thu, 21 Mar 2024 08:00:03 +0000

Your message dated Thu, 21 Mar 2024 09:56:30 +0200
with message-id <86msqs2f2p.fsf@gnu.org>
and subject line Re: bug#69927: [PATCH] Fix function vtable--recompute-numerical
has caused the debbugs.gnu.org bug report #69927,
regarding [PATCH] Fix function vtable--recompute-numerical
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69927: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69927
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Fix function vtable--recompute-numerical Date: Thu, 21 Mar 2024 02:20:36 -0500 User-agent: Mozilla Thunderbird
Hi,

Please see the attached patch which fixes the function `vtable--recompute-numerical'.

Thanks,
Adam

Attachment: 0001-Fix-vtable-recompute-numerical.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#69927: [PATCH] Fix function vtable--recompute-numerical Date: Thu, 21 Mar 2024 09:56:30 +0200
> Date: Thu, 21 Mar 2024 02:20:36 -0500
> From: Adam Porter <adam@alphapapa.net>
> 
> Please see the attached patch which fixes the function 
> `vtable--recompute-numerical'.

Thanks, installed on master, and closing the bug.

Btw, I noticed that you use a style for commit log messages that is
not our preferred style.  (I'm aware of the fact that a couple of
other contributors use such a style, and it is not completely wrong,
just a bit sub-optimal.)  The preferred style describes the summary of
the change in the heading line (so "git log --format=oneline" and its
ilk produce meaningful and useful output), then comes the expanded
description of the change and its rationale, and finally the actual
changes made in specific functions.  See the way I modified the log
message when installing the changes.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]