emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#70525: closed ([PATCH] Make auto-reveal customizations easier to ext


From: GNU bug Tracking System
Subject: bug#70525: closed ([PATCH] Make auto-reveal customizations easier to extend)
Date: Wed, 01 May 2024 13:59:02 +0000

Your message dated Wed, 01 May 2024 15:58:21 +0200
with message-id <m2h6fhprb6.fsf@macmutant.fritz.box>
and subject line Re: bug#70525: [PATCH] Make auto-reveal customizations easier 
to extend
has caused the debbugs.gnu.org bug report #70525,
regarding [PATCH] Make auto-reveal customizations easier to extend
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70525: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70525
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Make auto-reveal customizations easier to extend Date: Tue, 23 Apr 2024 05:54:51 +0200
External packages (e.g., a couple that I've written) may wish to
provide navigation commands that automatically reveal previews and
folds, but auto-reveal behavior is currently controlled by defcustoms,
such as preview-auto-reveal, that are not easily extended:

(defcustom preview-auto-reveal
  '(eval (preview-arrived-via (key-binding [left]) (key-binding [right])
                              #'backward-char #'forward-char))
  "...")

I attach a patch that addresses this, without affecting default
behavior, by changing the default value of preview-auto-reveal so that
it refers to a list, (defcustom preview-auto-reveal-commands).
Similarly for TeX-fold-auto-reveal.

Thanks, best,

Paul

Attachment: 0001-Make-auto-reveal-customizations-easier-to-extend.patch
Description: Source code patch


--- End Message ---
--- Begin Message --- Subject: Re: bug#70525: [PATCH] Make auto-reveal customizations easier to extend Date: Wed, 01 May 2024 15:58:21 +0200 User-agent: Gnus/5.13 (Gnus v5.13)
Paul Nelson <ultrono@gmail.com> writes:

> Do you see an advantage to modifying the behavior of the function
> rather than the default customization value?

I think it is cleaner; we have this sort of parsing also in other places
around within AUCTeX.  But since I'm currently not able to change this,
I've installed your patch.  We can revisit this later if necessary.

Again, thanks for the patch and also responding to my messages.
Closing.

Best, Arash


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]