bug#69780: closed ([PATCH 0/4] Simplify 'guix git authenticate' usage)

[GNU bug Tracking System]

Your message dated Wed, 01 May 2024 17:52:25 +0200
with message-id <87h6fh5y2u.fsf@gnu.org>
and subject line Re: [bug#69780] [PATCH v2 0/5] Simplify 'guix git 
authenticate' usage
has caused the debbugs.gnu.org bug report #69780,
regarding [PATCH 0/4] Simplify 'guix git authenticate' usage
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69780: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69780
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/4] Simplify 'guix git authenticate' usage
>
>
>
>
> Date: 
>
> Wed, 13 Mar 2024 18:40:13 +0100
>
>
>
>
> Hello Git! :-)
>
> ‘guix git authenticate’ has always been inconvenient because one
> has to provide the introduction (commit and signer) on the command
> line.
>
> Only recently did I realize that we could store that info in
> ‘.git/config’.  This is the main goal of this patch set.
>
> The rest further simplifies its use by discovering the repo and
> installing pre-push and post-checkout hooks.
>
> Thoughts?
>
> Ludo’.
>
> Ludovic Courtès (4):
>   git authenticate: Record introduction and keyring in ‘.git/config’.
>   git authenticate: Discover the repository.
>   git authenticate: Install pre-push and post-checkout hooks.
>   DRAFT news: Add entry for ‘guix git authenticate’ changes.
>
>  doc/guix.texi                     |  17 ++-
>  etc/news.scm                      |  16 +++
>  guix/scripts/git/authenticate.scm | 169 ++++++++++++++++++++++++------
>  tests/guix-git-authenticate.sh    |   9 +-
>  4 files changed, 174 insertions(+), 37 deletions(-)
>
>
> base-commit: 7b5c030684020282a690322b558f86718eb148a7
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#69780] [PATCH v2 0/5] Simplify 'guix git authenticate' usage
>
>
>
>
> Date: 
>
> Wed, 01 May 2024 17:52:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hello,
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > This is an update on <https://issues.guix.gnu.org/69780>.
> >
> > Changes since v1:
> >
> >   • Write config to the right file using the new
> >     ‘set-config-string’ procedure of Guile-Git.
> >
> >   • Write hooks to the right place (again, accounting for
> >     worktrees) using the new ‘repository-common-directory’
> >     procedure of Guile-Git.
> >
> >   • Support branch-specific configuration, as suggested by
> >     Skyler and Tomas.
> >
> >   • Create a post-merge hook rather than post-checkout, as
> >     suggested by Skyler.
> >
> >   • Add German translation by Florian and French translation
> >     of the news entry.
>
> [...]
>
> > If we agree on the patch set, I’ll tag Guile-Git 0.7.0 and
> > update it in Guix before applying these patches.
>
> I went ahead and pushed this patch series:
>
>   5c13ab50b9 news: Add entry for ‘guix git authenticate’ changes.
>   8d1d98a3aa git authenticate: Install pre-push and post-checkout hooks.
>   1a5041a502 git authenticate: Print something upon success.
>   88573dd928 git authenticate: Discover the repository.
>   7b4bf4ee88 git authenticate: Record introduction and keyring in ‘.git/config’.
>   10aa88ea01 gnu: guile-git: Update to 0.7.0.
>
> Thanks again for your insightful feedback!
>
> Ludo’.
>
>
> --- End Message ---