--- Begin Message ---
|
Subject: |
Re: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode |
|
Date: |
Thu, 8 Aug 2024 12:25:18 +1000 |
> On 8 Aug 2024, at 12:18, Paul W. Rankin <rnkn@rnkn.xyz> wrote:
>
> This is currently hard-coded and should instead be implemented as a
> user option, probably a hook, but this is outside the scope of this
> patch.
>
> <0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch>
Patched instead against current master.
0001-lisp-help-macro.el-remove-hard-coded-variable-pitch-.patch
Description: Binary data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode |
|
Date: |
Thu, 08 Aug 2024 13:34:00 +0300 |
> From: "Paul W. Rankin" <rnkn@rnkn.xyz>
> Date: Thu, 8 Aug 2024 19:57:18 +1000
> Cc: 72521@debbugs.gnu.org
>
> > On 8 Aug 2024, at 19:45, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Looks good, but I wonder whether a simple boolean user option would be
> > better, and also easier to customize. After all this is not a mode,
> > so people will not expect it to have a hook. Also, if someone doesn't
> > want variable-pitch-mode, I doubt they will want some other mode
> > instead, so the hook will most of the time be or the default or nil.
> >
> > WDYT?
>
> Agreed. I’ve added `help-for-help-use-variable-pitch’ boolean option.
> Although it’s a mouthful, I think this name is most discoverable since
> C-h C-k C-h C-h returns `help-for-help’, and there’s variable
> `help-for-help-buffer-name’.
Thanks, installed on the emacs-30 release branch, and closing the bug.
--- End Message ---