[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA-diffs] /srv/bzr/emacs/elpa r342: New package ggtags
From: |
Leo Liu |
Subject: |
Re: [ELPA-diffs] /srv/bzr/emacs/elpa r342: New package ggtags |
Date: |
Fri, 01 Feb 2013 02:03:06 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (OS X 10.8.2) |
On 2013-02-01 00:02 +0800, Stefan Monnier wrote:
> I think this is a misuse of `assert'. An `assert' should be used for
> something that should *never* be false (i.e. if it is false, we have
> a bug, possibly in the assertion itself). This is reflected in the fact
> that depending on optimization levels, CL can be told to "optimize-away"
> the assertions.
>
> So I think you want to use an explicit "test + error" above.
Thanks. I have fixed them.
Leo