Re: [PATCH] eww-mode-map doesn't bind TAB on tty.

[Mario Lang]

Lars Ingebrigtsen <address@hidden> writes:

> Eli Zaretskii <address@hidden> writes:
>
>>> [tab] is a function key, not the character TAB.  Try ?\t instead.
>>
>> And [?\M-\t] for backtab.
>
> Right; thanks.

`eww-text-map', `eww-textarea-map' and `shr-map' likely have the same
problem as `eww-mode-map' used to have:

--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -592,8 +592,8 @@ appears in a <link> or <a> tag."
     (define-key map [(control a)] 'eww-beginning-of-text)
     (define-key map [(control c) (control c)] 'eww-submit)
     (define-key map [(control e)] 'eww-end-of-text)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     map))
 
 (defvar eww-textarea-map
@@ -601,8 +601,8 @@ appears in a <link> or <a> tag."
     (set-keymap-parent map text-mode-map)
     (define-key map "\r" 'forward-line)
     (define-key map [(control c) (control c)] 'eww-submit)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     map))
 
 (defvar eww-select-map
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -147,8 +147,8 @@ cid: URL as the argument.")
     (define-key map "a" 'shr-show-alt-text)
     (define-key map "i" 'shr-browse-image)
     (define-key map "z" 'shr-zoom-image)
-    (define-key map [tab] 'shr-next-link)
-    (define-key map [backtab] 'shr-previous-link)
+    (define-key map [?\t] 'shr-next-link)
+    (define-key map [?\M-\t] 'shr-previous-link)
     (define-key map [follow-link] 'mouse-face)
     (define-key map [mouse-2] 'shr-browse-url)
     (define-key map "I" 'shr-insert-image)


And here is the result of grepping for the pattern in all Emacs Lisp files:

lisp/calendar/todo-mode.el:    (define-key map [tab] 'todo-next-button)
lisp/eshell/em-cmpl.el:  (define-key eshell-command-map [tab] 
'pcomplete-expand-and-complete)
lisp/eshell/em-cmpl.el:  (define-key eshell-mode-map [tab] 'eshell-pcomplete)
lisp/gnus/gnus-html.el:    (define-key map [tab] 'widget-forward)
lisp/image-dired.el:  (define-key image-dired-thumbnail-mode-map [tab] 
'image-dired-jump-original-dired-buffer)
lisp/image-dired.el:  (define-key dired-mode-map [tab] 
'image-dired-jump-thumbnail-buffer)
lisp/international/quail.el:    (define-key map [tab] 'quail-completion)
lisp/kmacro.el:    (define-key map [tab] 'act-repeat)
lisp/play/5x5.el:    (define-key map [tab]                     #'5x5-right)

-- 
CYa,
  ⡍⠁⠗⠊⠕