emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.


From: martin rudalics
Subject: Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.
Date: Tue, 11 Mar 2014 09:07:46 +0100

> When reverting a change, always leave some trace about the reason for
> the reversion.  E.g. add a comment, or at least a change-log message
> pointing to the problem introduced by the code that justified the reversion.
>
> If the reversion is because the original change was simply a pilot error
> (never intended to commit it), then the change log should say so.  Else,
> a comment in the code should explain the problem so that someone else
> won't go through the same fruitless change.

I halfheartedly added a comment.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]