emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unnecessary variable shr-start


From: Matthew Carter
Subject: Re: Unnecessary variable shr-start
Date: Sat, 03 Dec 2016 01:54:17 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Michael Heerdegen <address@hidden> writes:

> Hong Xu <address@hidden> writes:
>
>> In the current master branch, it seems that the variable shr-start has
>> never been used in any sensible way: Every time its value is referred,
>> it is bound to nil. Should it be considered to be removed?
>
> Are you sure it is always bound to nil when referenced in `shr-tag-a'?
> I would expect it can be changed by side effect in the body, and the
> let-binding is there to make that change temporary.
>
>
> Michael.
>

It looks like it's bound at the top defvar level (and changed via setq
in the img function), so those let's to nil in certain functions are
likely to inhibit the current setting when those functions begin to
run.

-- 
Matthew Carter (address@hidden)
http://ahungry.com



reply via email to

[Prev in Thread] Current Thread [Next in Thread]