[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 618310c: Work on `tramp-completion-mode-p'
From: |
Dmitry Gutov |
Subject: |
Re: [Emacs-diffs] master 618310c: Work on `tramp-completion-mode-p' |
Date: |
Tue, 28 Feb 2017 02:06:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 26.02.2017 13:45, Michael Albinus wrote:
(progn (defun tramp-completion-mode-p ()
"Check, whether method / user name / host name completion is active."
(or
;; Signal from outside. `non-essential' has been introduced in Emacs 24.
(and (boundp 'non-essential) (symbol-value 'non-essential))
- tramp-completion-mode)))
+ ;; This variable has been obsoleted in Emacs 26.
+ tramp-completion-mode
+ ;; Fallback. Some completion packages still don't support
+ ;; `non-essential' sufficiently.
Any packages in particular? Should we try working with their authors?
+ (equal last-input-event 'tab))))
Not sure I understand what's going on here. It seems you are making
`non-essential' being non-nil and `tab' being the last input event have
the same impact.
Whereas, IME, the user pressing TAB usually means that the completion
operation *is essential*, and they would probably be willing to input
their connection credentials if necessary.
Like the discussion in https://debbugs.gnu.org/25607 has touched on.
- Re: [Emacs-diffs] master 618310c: Work on `tramp-completion-mode-p',
Dmitry Gutov <=