Re: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change.

[Stefan Monnier]

> But we only care what happens with these between two successive
> redisplay cycles.  What kind of scenario could possibly change that
> variable in more than one buffer?

Here's a situation:

    (with-current-buffer A
      (setq-local overlay-arrow-position (copy-marker 10)))
    (with-current-buffer B
      (setq-local overlay-arrow-position (copy-marker 5)))

after redisplay, what should be the value of

    (get 'overlay-arrow-position 'last-arrow-position)

?  If it's 5 and we perform a redisplay, will buffer A be refreshed even
if no changes occurred in it?

The way I look at it, this code fundamentally assumes that the variables
on that list are not buffer-local (not only because of the use of
global symbol properties but also because it only considers
the value of those vars in the buffer which happens to be current).

Yet:

    % grep -l local.\*overlay-arrow-position **/*.el
    calc/calc.el
    gnus/gnus-sum.el
    mpc.el
    net/rcirc.el
    progmodes/compile.el
    progmodes/python.el
    %

And from my understanding of how this code works, we can both end up
redisplaying unnecessarily, as well as fail to redisplay when needed.


        Stefan